chore: raise the umd bundle size ceiling to 3.25 mb - #167
Merged
Conversation
|
🎉 This PR is included in version 2.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UMD ceiling was set at exactly 3 MB and
mainships at 2.9973 MB — 2.8 KB of headroom. Any feature of any size trips it, so the check now fires on arrival rather than on a regression, which is not what a size ratchet is for.3.25 MB restores its purpose: catch a jump, ignore a creep. The other three bundles keep their existing limits and still have room (ES 3.71/4.0, internal UMD 2.11/2.5, internal ES 2.52/3.0).
Verify:
npm run test:packageRisk: a genuine size regression up to 250 KB would now pass unflagged. Accepted — the alternative is a check that blocks every merge.